Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves usage of ci tests by not relying on github paths #190

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

hsubbaraj-spiral
Copy link
Contributor

@hsubbaraj-spiral hsubbaraj-spiral commented Jul 5, 2022

Describe your changes and why you are making these changes

The path/ignore path conditions used by Github Actions are very broad for our use cases. Often times users will update documentation in the same PR that they make code changes in, and this will trigger both the testing/skip-testing workflows. The best way to configure this is to leave it up to the developer to decide when to run/skip the tests. The new behavior is as follows:

  • Add run_integration_test label: Runs integration tests
  • Add skip_integration_test label: Skips integration tests (Should be used when changes are ONLY documentation/UI)

One of these labels must be added in order to merge the PR.

Related issue number (if any)

https://linear.app/aqueducthq/issue/ENG-1304/fix-issues-with-integration-test-ci

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [n/a] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [n/a] If this is a new feature, I have added unit tests and integration tests.
  • I have manually run the integration tests and they are passing.
  • [n/a] All features on the UI continue to work correctly.

@hsubbaraj-spiral hsubbaraj-spiral added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jul 5, 2022
@hsubbaraj-spiral hsubbaraj-spiral requested a review from cw75 July 5, 2022 17:31
.github/pull_request_template.md Outdated Show resolved Hide resolved
@hsubbaraj-spiral hsubbaraj-spiral requested a review from cw75 July 6, 2022 00:29
@hsubbaraj-spiral hsubbaraj-spiral merged commit 1a5945f into main Jul 6, 2022
@hsubbaraj-spiral hsubbaraj-spiral deleted the update-skip-test-conditions branch July 6, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants